reload the page to show 404 when receiving invalid event from on-demand-entries

[sokra]

This fixes a race-condition when changes happens exactly during page load when the EventSource is not yet fully connected. It already causes some flaky tests.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

[ijjk]

Failing test suites

Commit: 8882513

test/integration/client-navigation/test/index.test.js

• Client Navigation > should not reload when visiting /_error directly

Expand output

● Client Navigation › should not reload when visiting /_error directly

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: undefined

  37 |     // reloading non-stop
  38 |     for (let i = 0; i < 15; i++) {
> 39 |       expect(await browser.eval('window.hello')).toBe(true)
     |                                                  ^
  40 |       await waitFor(1000)
  41 |     }
  42 |     const html = await browser.eval('document.documentElement.innerHTML')

  at Object.<anonymous> (integration/client-navigation/test/index.test.js:39:50)

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
buildDuration	13.7s	13.9s	⚠️ +164ms
buildDurationCached	3.4s	3.5s	⚠️ +12ms
nodeModulesSize	47 MB	47 MB	⚠️ +643 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.217	3.182	-0.04
/ avg req/sec	777.16	785.63	+8.47
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.719	1.634	-0.09
/error-in-render avg req/sec	1454.58	1529.57	+74.99

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.6 kB	26.6 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.4 kB	70.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
index.html gzip	539 B	539 B	✓
link.html gzip	552 B	552 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

---

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
buildDuration	11.7s	11.1s	-538ms
buildDurationCached	4.7s	4.8s	⚠️ +61ms
nodeModulesSize	47 MB	47 MB	⚠️ +643 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.313	3.2	-0.11
/ avg req/sec	754.6	781.19	+26.59
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.902	1.703	-0.2
/error-in-render avg req/sec	1314.11	1468.17	+154.06

Client Bundles (main, webpack, commons)

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	13.8 kB	13.8 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	71.2 kB	71.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js bugfix/consistent-reload	Change
index.html gzip	585 B	585 B	✓
link.html gzip	597 B	597 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: d012a50