-
Notifications
You must be signed in to change notification settings - Fork 26.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Redux example to use Toolkit + update dependencies. #29104
Conversation
Looks great! (my only concern, tbh, is that by pinging me in your comment it might end up as part of the commit message when squashed, and that's what led to me getting a bunch of random notifications when people cloned another example earlier.) |
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, seems lint-fix
might need to be run though
Sorry about that, Mark! Thank you @ijjk 😄 |
Your local |
Interesting, shouldn't it use the version in |
Yeah, is it not updating after running |
🤕 I need to update the packages first, good point 😆 |
* canary: (41 commits) Add client-side debugging instructions (vercel#28815) v11.1.3-canary.19 Update next-swc binaries (vercel#29132) Fix partial one off global selectors (vercel#29128) Update trace ignores for next import (vercel#29119) Development tracing improvements (vercel#29076) Remove log from failing to parse source map (vercel#29118) Remove inert font tag in font optimization (vercel#28869) v11.1.3-canary.18 Update Redux example to use Toolkit + update dependencies. (vercel#29104) Ensure browser instances are not re-created un-necessarily (vercel#29091) Update styled-jsx (vercel#29103) v11.1.3-canary.17 Add/styled jsx swc (vercel#29005) v11.1.3-canary.16 Fix host segment replacing for custom routes (vercel#29090) Add stats config for SWC (vercel#28883) reload the page to show 404 when receiving `invalid` event from on-demand-entries (vercel#29074) Add crossOrigin type to the NextConfig (vercel#29033) Fix/upload binary artifact (vercel#29069) ...
Hi, as the main distinctive feature of next js (at least for me) is the ability to use ssr and ssg, there really is no point in using next with redux without being able to use ssr and ssg. Using this example I am able to fetch data and store it into redux on the server side but it does not hydrate on the client side, can you do another example or update this one to enable the ability to use ssr and ssg peoperly with redux toolkit? Thank you for the great work done so far, and I hope you can do this as it will surely be appreciated by many people. |
After talking with markerikson, I've made some updates to the Redux examples:
with-redux
example to use the Redux Toolkit + TypeScript examplewith-redux
to work with latest testing setupwith-redux-toolkit
in favor ofwith-redux
with-redux-toolkit-typescript
in favor ofwith-redux
with-redux-code-splitting
in favor ofwith-redux