-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Feat: Add deno support in create-next-app and add docs #71396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
why did Job unable able to validate for brrock on PR #71396 fail what does that mean |
Author
1 similar comment
Author
Author
|
Can I see some activity any news guys |
Member
|
@brrock Taking a look! |
Contributor
|
Thank you for the docs updates @brrock, could you please resolve the merge conflicts? 🙏🏼 |
Author
|
Yep |
Author
|
Sorry for slow response |
Author
|
All ready to go |
Author
|
@samcx ready to review |
leerob
reviewed
Dec 3, 2024
docs/01-app/02-building-your-application/08-testing/03-playwright.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Lee Robinson <lee@leerob.com>
Author
|
Ready |
Author
Member
|
@brrock Looks like there are still merge conflicts! |
Author
|
Sorting out when I get home |
Author
|
About to remake |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
Documentation
Related to Next.js' official documentation.
locked
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

For Contributors
Improving Documentation
pnpm prettier-fixto fix formatting issues before opening the PR.Adding or Updating Examples
pnpm build && pnpm lint. See linting guidelines.Fixing a Bug
fixes #number.Adding a Feature
fixes #number.For Maintainers
What?
This PR adds support for using Deno in create-next-app, allowing the user to use Deno as a package manager with the same flag that works for pnpm or yarn. It also detects if the script is run using Deno.
Why?
Deno is gaining fast adoption with its new 2.0 update. It’s much faster than npm and has many additional features.
How?
get-pkg-manager.ts, the code checks if the Deno type exists, which will only happen if you run the script using Deno.install.ts, it checks if the package manager is Deno based on the last file.index.ts, it implements the--use-denoflag to indicate that Deno is being used as the package manager.