Skip to content

Conversation

@brrock
Copy link

@brrock brrock commented Oct 16, 2024

  • Feat: Add Deno support in create-next-app
  • Chore: Lint
  • Add docs in the testing section to install needed packages for testing

For Contributors

Improving Documentation

  • Run pnpm prettier-fix to fix formatting issues before opening the PR.
  • Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines.

Adding or Updating Examples

Fixing a Bug

Adding a Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see discussion thread).
  • Related issues/discussions are linked using fixes #number.
  • End-to-end tests added: e2e tests.
  • Documentation added.
  • Telemetry added to determine feature usage.
  • Errors have a helpful link attached, see contributing guidelines.

For Maintainers

  • Minimal description (aim for explaining to someone not on the team to understand the PR).
  • When linking to a Slack thread, consider sharing details of the conclusion.
  • Link both the Linear (Fixes NEXT-xxx) and the GitHub issues.
  • Add review comments if necessary to explain the logic behind a change.

What?

This PR adds support for using Deno in create-next-app, allowing the user to use Deno as a package manager with the same flag that works for pnpm or yarn. It also detects if the script is run using Deno.

Why?

Deno is gaining fast adoption with its new 2.0 update. It’s much faster than npm and has many additional features.

How?

  • In get-pkg-manager.ts, the code checks if the Deno type exists, which will only happen if you run the script using Deno.
  • In install.ts, it checks if the package manager is Deno based on the last file.
  • In index.ts, it implements the --use-deno flag to indicate that Deno is being used as the package manager.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 16, 2024
@brrock brrock marked this pull request as ready for review October 16, 2024 18:02
@brrock
Copy link
Author

brrock commented Oct 16, 2024

why did Job unable able to validate for brrock on PR #71396 fail what does that mean

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Oct 16, 2024
@brrock
Copy link
Author

brrock commented Oct 17, 2024

@ijjk

1 similar comment
@brrock
Copy link
Author

brrock commented Oct 17, 2024

@ijjk

@brrock brrock changed the title Feat: Add deno support in create-next-app Feat: Add deno support in create-next-app and add docs Oct 17, 2024
@brrock
Copy link
Author

brrock commented Oct 21, 2024

Can I see some activity any news guys

@samcx samcx self-requested a review November 26, 2024 18:27
@samcx
Copy link
Member

samcx commented Nov 26, 2024

@brrock Taking a look! :one-eye-cowboy:

@delbaoliveira
Copy link
Contributor

Thank you for the docs updates @brrock, could you please resolve the merge conflicts? 🙏🏼

@brrock
Copy link
Author

brrock commented Dec 1, 2024

Yep

@brrock
Copy link
Author

brrock commented Dec 1, 2024

Sorry for slow response

@brrock
Copy link
Author

brrock commented Dec 1, 2024

All ready to go

@brrock
Copy link
Author

brrock commented Dec 1, 2024

@samcx ready to review

brrock and others added 2 commits December 9, 2024 07:53
Co-authored-by: Lee Robinson <lee@leerob.com>
@brrock
Copy link
Author

brrock commented Dec 9, 2024

Ready

@brrock
Copy link
Author

brrock commented Dec 9, 2024

@leerob

@samcx
Copy link
Member

samcx commented Dec 17, 2024

@brrock Looks like there are still merge conflicts!

@brrock
Copy link
Author

brrock commented Dec 19, 2024

Sorting out when I get home

@brrock brrock closed this Apr 12, 2025
@brrock
Copy link
Author

brrock commented Apr 12, 2025

About to remake

@brrock brrock deleted the canary branch April 12, 2025 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

create-next-app Related to our CLI tool for quickly starting a new Next.js application. Documentation Related to Next.js' official documentation. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants