-
Couldn't load subscription status.
- Fork 29.7k
docs: fix proxy matcher overflow #85337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All broken links are now fixed, thank you! |
| > | ||
| > - In Proxy, you can also read cookies using `req.cookies.get('session').value`. | ||
| > - Proxy uses the [Edge Runtime](/docs/app/api-reference/edge), check if your Auth library and session management library are compatible. | ||
| > - Proxy uses the Node.js runtime, check if your Auth library and session management library are compatible. You may need to use [Middleware](https://github.com/vercel/next.js/blob/v15.5.6/docs/01-app/03-api-reference/03-file-conventions/middleware.mdx) if your Auth library only supports [Edge Runtime](/docs/app/api-reference/edge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > - Proxy uses the Node.js runtime, check if your Auth library and session management library are compatible. You may need to use [Middleware](https://github.com/vercel/next.js/blob/v15.5.6/docs/01-app/03-api-reference/03-file-conventions/middleware.mdx) if your Auth library only supports [Edge Runtime](/docs/app/api-reference/edge) | |
| > - Proxy uses the Node.js runtime, check if your Auth library and session management library are compatible. You may need to use [Proxy](/docs/app/api-reference/file-conventions/proxy) if your Auth library only supports [Edge Runtime](/docs/app/api-reference/edge) |
Line 1124 contains a broken GitHub link to deprecated middleware documentation. The link should reference the internal documentation for Proxy instead: /docs/app/api-reference/file-conventions/proxy.
View Details
Analysis
Broken documentation link in authentication guide
What fails: Line 1124 in docs/01-app/02-guides/authentication.mdx contains an incorrect documentation link pointing to a GitHub URL for deprecated middleware documentation.
How to reproduce:
- Open
docs/01-app/02-guides/authentication.mdx - Navigate to line 1124
- The link text reads
[Middleware](https://github.com/vercel/next.js/blob/v15.5.6/docs/01-app/03-api-reference/03-file-conventions/middleware.mdx)
What happened vs expected behavior:
- The link pointed to a GitHub blob URL targeting a non-existent
middleware.mdxfile (deprecated in favor ofproxy) - Expected: Link should point to the internal documentation path
/docs/app/api-reference/file-conventions/proxyand display[Proxy]as the link text - The pattern matches existing correct usage at line 1026 in the same file
Fix applied: Changed line 1124 from:
[Middleware](https://github.com/vercel/next.js/blob/v15.5.6/docs/01-app/03-api-reference/03-file-conventions/middleware.mdx)
to:
[Proxy](/docs/app/api-reference/file-conventions/proxy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the time being, I reckon we need to link to some documentation about Middleware for those who are using Edge runtime.
Also closes: #85344