Skip to content

Remove unused Server.responseCache #86768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mischnic merged 1 commit into from
Dec 3, 2025
Merged

Remove unused Server.responseCache #86768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/next/src/server/base-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ import type {
RenderOptsPartial as AppRenderOptsPartial,
ServerOnInstrumentationRequestError,
} from './app-render/types'
import type {
ServerComponentsHmrCache,
ResponseCacheBase,
} from './response-cache'
import type { ServerComponentsHmrCache } from './response-cache'
import type { UrlWithParsedQuery } from 'url'
import {
NormalizeError,
Expand Down Expand Up @@ -329,7 +326,6 @@ export default abstract class Server<
protected interceptionRoutePatterns: RegExp[]
protected nextFontManifest?: DeepReadonly<NextFontManifest>
protected instrumentation: InstrumentationModule | undefined
private readonly responseCache: ResponseCacheBase

protected abstract getPublicDir(): string
protected abstract getHasStaticDir(): boolean
Expand Down Expand Up @@ -396,10 +392,6 @@ export default abstract class Server<
requestHeaders: Record<string, undefined | string | string[]>
}): Promise<import('./lib/incremental-cache').IncrementalCache>

protected abstract getResponseCache(options: {
dev: boolean
}): ResponseCacheBase

protected getServerComponentsHmrCache():
| ServerComponentsHmrCache
| undefined {
Expand Down Expand Up @@ -569,7 +561,6 @@ export default abstract class Server<
void this.matchers.reload()

this.setAssetPrefix(assetPrefix)
this.responseCache = this.getResponseCache({ dev })
}

protected reloadMatchers() {
Expand Down
4 changes: 0 additions & 4 deletions packages/next/src/server/next-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,6 @@ export default class NextNodeServer extends BaseServer<
})
}

protected getResponseCache() {
return new ResponseCache(this.minimalMode)
}

protected getPublicDir(): string {
return join(/* turbopackIgnore: true */ this.dir, CLIENT_PUBLIC_FILES_PATH)
}
Expand Down
Loading