-
Notifications
You must be signed in to change notification settings - Fork 100
Add "etag" response header #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Utilize the `etag` module on npm to send an "etag" response header.
leo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to generate strong ETags, as the content is 100% static. In turn, I'd suggest generating a sha1 from the stream.
Also, from the package docs (but it's more or less obvious):
By default, a strong ETag is generated except for fs.Stats, which will generate a weak ETag.
This reverts commit 3c20819.
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 324 324
=====================================
Hits 324 324Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 324 343 +19
=====================================
+ Hits 324 343 +19
Continue to review full report at Codecov.
|
Utilize the
etagmodule on npm to send an "etag" response header.