-
Notifications
You must be signed in to change notification settings - Fork 111
fix: port detection, postgres nitro apps and nitro app testing #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ae1b490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
VaguelySerious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only downside is we're now using execa which seems quite large as a library just for optimizing a small amount of shell commands. After merging this, might be nice to vibe code a refactor follow-up that removes the execa dependency, given the tests look comprehensive, hopefully that's a one-shot
ah yeah i was originally using |
pid-portfromgetPortmethod because internally it usesnetstatwhich is not reliablecloses #400