Skip to content

Conversation

@adriandlam
Copy link
Member

@adriandlam adriandlam commented Nov 18, 2025

  • removes pid-port from getPort method because internally it uses netstat which is not reliable
  • adds a delay between dev test and e2e test which was causing a race condition between nitro apps rebuilding from cleanup and invoking the first workflow from the e2e test
  • fixes starting postgres world in nitro apps

closes #400

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: ae1b490

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/world-local Patch
@workflow/utils Patch
@workflow/cli Patch
@workflow/core Patch
@workflow/world-postgres Patch
@workflow/errors Patch
workflow Patch
@workflow/world-testing Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
@workflow/world-vercel Patch
@workflow/ai Patch
@workflow/sveltekit Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 24, 2025 3:57am
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 24, 2025 3:57am
example-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-astro-workflow Error Error Nov 24, 2025 3:57am
workbench-express-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-hono-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-nitro-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-nuxt-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-sveltekit-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workbench-vite-workflow Ready Ready Preview Comment Nov 24, 2025 3:57am
workflow-docs Ready Ready Preview Comment Nov 24, 2025 3:57am

Copy link
Member

@VaguelySerious VaguelySerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only downside is we're now using execa which seems quite large as a library just for optimizing a small amount of shell commands. After merging this, might be nice to vibe code a refactor follow-up that removes the execa dependency, given the tests look comprehensive, hopefully that's a one-shot

@adriandlam
Copy link
Member Author

LGTM, only downside is we're now using execa which seems quite large as a library just for optimizing a small amount of shell commands. After merging this, might be nice to vibe code a refactor follow-up that removes the execa dependency, given the tests look comprehensive, hopefully that's a one-shot

ah yeah i was originally using execFileSync but came across execa (which is what pid-port) was using. i'll do that in a different PR

@adriandlam adriandlam merged commit edb69c3 into main Nov 24, 2025
89 of 91 checks passed
@adriandlam adriandlam deleted the fix/nitro-app-workaround branch November 24, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ECONNREFUSED - Queue operation failed

4 participants