Fix default export workflow function transformation in workflow mode #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where default export workflow functions with names (e.g., `export default async function testWorkflow()`) would fail at runtime with `ReferenceError: $$default is not defined`. The SWC plugin now correctly keeps the default export as-is and simply adds the workflowId assignment after it, since the function name is available as a binding in the module scope. Fixes #367.
🦋 Changeset detectedLatest commit: dfa4112 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pranaygp
reviewed
Nov 20, 2025
| @@ -0,0 +1,8 @@ | |||
| // Test anonymous default export workflow | |||
| /**__internal_workflows{"workflows":{"input.js":{"default":{"workflowId":"workflow//input.js//defaultWorkflow"}}}}*/; | |||
| const defaultWorkflow = async function() { | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| const defaultWorkflow = async function() { | |
| const __default = async function() { |
pranaygp
reviewed
Nov 20, 2025
Comment on lines
7
to
8
| defaultWorkflow.workflowId = "workflow//input.js//defaultWorkflow"; | ||
| export default defaultWorkflow; |
Collaborator
There was a problem hiding this comment.
Suggested change
| defaultWorkflow.workflowId = "workflow//input.js//defaultWorkflow"; | |
| export default defaultWorkflow; | |
| defaultWorkflow.workflowId = "workflow//input.js//__default"; | |
| export default __default; |
pranaygp
reviewed
Nov 20, 2025
| @@ -1,5 +1,5 @@ | |||
| // Test workflow functions in client mode | |||
| /**__internal_workflows{"workflows":{"input.js":{"arrowWorkflow":{"workflowId":"workflow//input.js//arrowWorkflow"},"defaultWorkflow":{"workflowId":"workflow//input.js//defaultWorkflow"},"internalWorkflow":{"workflowId":"workflow//input.js//internalWorkflow"},"myWorkflow":{"workflowId":"workflow//input.js//myWorkflow"}}}}*/; | |||
| /**__internal_workflows{"workflows":{"input.js":{"arrowWorkflow":{"workflowId":"workflow//input.js//arrowWorkflow"},"default":{"workflowId":"workflow//input.js//defaultWorkflow"},"internalWorkflow":{"workflowId":"workflow//input.js//internalWorkflow"},"myWorkflow":{"workflowId":"workflow//input.js//myWorkflow"}}}}*/; | |||
Collaborator
There was a problem hiding this comment.
this looks like a bug no? the function here is called defaultWorkflow
pranaygp
reviewed
Nov 20, 2025
Comment on lines
11
to
13
| export default async function defaultWorkflow() { | ||
| return await process(); | ||
| } |
Collaborator
There was a problem hiding this comment.
interesting case of exporting a named default workflow
pranaygp
approved these changes
Nov 20, 2025
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where default export workflow functions with names (e.g.,
export default async function testWorkflow()) would fail at runtime withReferenceError: $$default is not defined. The SWC plugin now correctly keeps the default export as-is and simply adds the workflowId assignment after it, since the function name is available as a binding in the module scope.Also adds support for anonymous and arrow function default exports, which previously were not being transformed at all.
Fixes #367.