postgres: fix tests #394
Merged
postgres: fix tests #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Schniz
force-pushed
the
schniz/fix-postgres-tests
branch
from
1ab3bf2 to
475eef6
Compare
Schniz
force-pushed
the
schniz/fix-postgres-tests
branch
from
75ed5d9 to
61551fb
Compare
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
…obal and a symbol. this makes sure that streamers can use in-memory event emitters and that it won't be compiled away into the different flow.js and step.js files. this was figured out when i was adding a hooks tests to world-testing. Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
we try to run them with the postgres world but it's not installed Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
…eleased. so initial attempt in postgres should reflect that. Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Schniz
force-pushed
the
schniz/fix-postgres-tests
branch
from
16fcdd8 to
c79a301
Compare
pranaygp
approved these changes
Nov 23, 2025
| customType, | ||
| index, | ||
| integer, | ||
| /** @deprecated: use Cbor instead */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few unimplemented things or Postgres-specific quirks were fixed to make sure the e2e tests now pass (at least in Next.js)
.getcalls. The CBOR columns have the same name but with a_cborsuffix, and stored asbytea(blobs), allowing us to store nested binary structures and the null byte\x00within a string.createfunction. Fixed.getWorldandsetWorldwere setting a module instance variable. This is okay generally but the problem is that we will have 3 different module scopes due to our bundling strategy that doesn't treat@workflow/coreas external:flow.jsstep.jsworkflow/apior whatever that uses them@workflow/world-postgresto all workbench/* apps, otherwise starting them with that workflow world target will failEvery breaking change I had in the e2e tests was copied (in some form) to the
@workflow/world-testing, which is a package that world authors can use to verify spec compliance. The more tests we have there, the better, as it allows our users to trust custom worlds and distribute their own ideas without being afraid of something breaking.