Skip to content

Some housekeeping on unnecessary dependencies #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
Merged

Some housekeeping on unnecessary dependencies #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bd7074
Some housekeeping on unnecessary dependencies
TooTallNate Oct 25, 2025
3cca760
.
TooTallNate Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-otters-sin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@workflow/world": patch
---

Remove `@types/json-schema` dependency (not used)
5 changes: 5 additions & 0 deletions .changeset/evil-mammals-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@workflow/world": patch
---

Remove `@types/node` from being a peerDependency
5 changes: 5 additions & 0 deletions .changeset/two-rabbits-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@workflow/cli": patch
---

Move `@types/watchpack` to be a devDependency
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@
},
"devDependencies": {
"@types/node": "catalog:",
"@types/watchpack": "2.4.4",
"@workflow/tsconfig": "workspace:*"
},
"dependencies": {
"@oclif/core": "^4.0.0",
"@oclif/plugin-help": "^6.0.0",
"@swc/core": "1.11.24",
"@types/watchpack": "2.4.4",
"@workflow/swc-plugin": "workspace:*",
"@workflow/errors": "workspace:*",
"@workflow/core": "workspace:*",
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/serialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ export class WorkflowServerWritableStream extends WritableStream<Uint8Array> {
}
const world = getWorld();
super({
write: async (chunk: string | Uint8Array | Buffer) => {
async write(chunk) {
await world.writeToStream(name, chunk);
},
close: async () => {
async close() {
await world.closeStream(name);
},
});
Expand Down
3 changes: 0 additions & 3 deletions packages/world/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,10 @@
"dev": "tsc --watch"
},
"peerDependencies": {
"@types/node": "catalog:",
"@types/json-schema": "catalog:",
"zod": "catalog:"
},
"devDependencies": {
"@types/node": "catalog:",
"@types/json-schema": "catalog:",
"zod": "catalog:",
"@workflow/tsconfig": "workspace:*"
},
Expand Down
5 changes: 1 addition & 4 deletions packages/world/src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ import type {
} from './steps.js';

export interface Streamer {
writeToStream(
name: string,
chunk: string | Uint8Array | Buffer
): Promise<void>;
writeToStream(name: string, chunk: string | Uint8Array): Promise<void>;
closeStream(name: string): Promise<void>;
readFromStream(
name: string,
Expand Down
Loading