String functions (trim, left, right, mid) - supports non string parameter #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verhas
requested changes
Jan 27, 2020
src/main/java/com/scriptbasic/utility/functions/StringFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/scriptbasic/utility/functions/StringFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/scriptbasic/utility/functions/StringFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/scriptbasic/utility/functions/StringFunctions.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for your suggestions. I added test on null and also two new functions (CStr and IsNull). If you will have a minute please review the changes..... |
PetrPytelka
force-pushed
the
string_functions_with_non_string_param
branch
from
44c28eb to
c8eb9ac
Compare
verhas
requested changes
Feb 9, 2020
| com.scriptbasic.classification.Utility.class}) | ||
| static public String ltrim(final String s) { | ||
| static public String ltrim(final Object o) throws BasicRuntimeException { | ||
| if(o==null) { |
Contributor
Author
There was a problem hiding this comment.
Formatting was fixed.
| assert("rtrim", rtrim(v)=" 1234") | ||
|
|
||
| ' Test null values | ||
| assert("ltrim_with_null", IsNull(ltrim(xxx))) |
Owner
There was a problem hiding this comment.
instead of xxx you could use undef. More expressive.
Contributor
Author
There was a problem hiding this comment.
I renamed variable name.
PetrPytelka
force-pushed
the
string_functions_with_non_string_param
branch
from
c8eb9ac to
1666063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String functions (trim, left, right, mid) - supports null parameter and numerical parameter, improved VB/VBA compatibility