-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/simplify service operations and more #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JohanHjelsethStorstad
merged 32 commits into
main
from
refactor/simplify-service-operations-and-more
Oct 11, 2025
Merged
Refactor/simplify service operations and more #448
JohanHjelsethStorstad
merged 32 commits into
main
from
refactor/simplify-service-operations-and-more
Oct 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanHjelsethStorstad
approved these changes
Oct 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work now
ablerto
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #443.
This PR simplifies the interface for service methods.
Before:
After:
This PR also moves all the actions from their own folder
src/actions
to a dedicatedactions.ts
file per service insrc/services
.Finally, this PR replaces namespaces with objects as that is what the docs officialy recommend. Excert:
There were som problems with self referential service before, but 90% of that has been fixed by removing an unecessary generic from the auhter.