Updates to support SpaceTime (new isvhsopen.com system) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relaxed sanitization for data values to permit period, space, and colon characters.
Added URI matching for dual-dataname query for fullpage, which uses template 'data-dual-full'.
path: '/s/{spacename}/data/{dataname1}/{dataname2}/fullpage'
This template is for displaying two datapoints at once. Visually, datapoint1 is the primary datapoint, and datapoint2 is the secondary. The primary use for this is for the new isvhsopen.com. datapoint1.value will be either 'closed' or 'open' and datapoint2.value might be 'until 12:45'. CSS formatting is specifically designed for this to look good, but other datapoint values will still work fine. Note that the "as of" tooltip only shows the last updated time of datapoint1.
|
LGTM, merging. |
interlock
added a commit
that referenced
this pull request
Oct 3, 2015
Updates to support SpaceTime (new isvhsopen.com system)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update isvhsopen.com to work with SpaceTime (https://github.com/vhs/SpaceTime).
The new isvhsopen.com will have two datapoints:
door - values are 'open' or 'closed'
isvhsopen_until - 'until 12:35' or ''
This update includes changes to input santization (now allows period, colon, and space) and a new fullpage template 'data-dual-full.tt' that displays two datapoints on the same page.
(Note that the previous, similar pull request was for the perl codebase. Since we've changed to javascript, this is those same changes applied to the new codebase.)