DATA-1109 - Add training start time to metadata #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 570d996.
agreenb
approved these changes
Nov 9, 2023
agreenb
left a comment
agreenb
left a comment
There was a problem hiding this comment.
LGTM!
Can you check that this doesn't cause any linter errors in app? It shouldn't since we're not creating a TrainingJobMetadata (and if we were, the linter would complain that some fields are not explicitly set) and instead just passing it through. Can check this locally with app pointing to this PR and running cd frontend && npm run lint
tahiyasalam
added
enhancement
tahiyasalam
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes staged here. I tested everything locally, but I will merge, update API and
Deployonce this is merged.