Skip to content

Conversation

@acmorrow
Copy link
Member

No description provided.

@acmorrow acmorrow requested a review from a team as a code owner February 16, 2024 16:29
@acmorrow acmorrow requested review from benjirewis and stuqdog and removed request for a team, benjirewis and stuqdog February 16, 2024 16:29
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

}

void reconfigure(vsdk::Dependencies dependencies, vsdk::ResourceConfig configuration) final
void reconfigure(const vsdk::Dependencies& dependencies, const vsdk::ResourceConfig& configuration) final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sorry I missed this!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries - I actually forgot about it too, but then I was going to actually use this module for something and realized it was out of date!

@acmorrow acmorrow merged commit 263cdd3 into viamrobotics:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants