RSDK-6726 - update client types in c++ code samples #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
njooma and
purplenicole730
and removed request for
a team
purplenicole730
approved these changes
Mar 1, 2024
stuqdog
commented
Mar 5, 2024
Comment on lines
+314
to
+316
| impl_(std::make_unique<impl>(RobotService::NewStub(channel_))) { | ||
| Registry::initialize(); | ||
| } |
Member
Author
There was a problem hiding this comment.
(flyby) we need to ensure that the Registry is properly initialized even when functioning as a pure client. This isn't a great long-term fix but @acmorrow has some future work on library initialization that will help clear this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apis.jsonwas still passingFooClientas the client type for code samples, leading toresource_by_name<FooClient>(...)rather than the now-correctresource_by_name<Foo>(...). This PR fixes that.