Skip to content

Conversation

@lia-viam
Copy link
Collaborator

Some other stuff arguably would have fit under this ticket but wanted to keep this PR more digestible

@lia-viam lia-viam requested a review from stuqdog December 13, 2024 19:25
@lia-viam lia-viam requested a review from a team as a code owner December 13, 2024 19:25
@lia-viam lia-viam requested review from njooma and removed request for a team December 13, 2024 19:25

/// @class API
/// @brief Extends `APIType` to additionally define a resource's subtype (e.g., `camera`).
// TODO: Maybe just merge these two classes or at least use composition rather than inheritance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lia-viam lia-viam merged commit 27c0697 into viamrobotics:main Dec 18, 2024
4 checks passed
@lia-viam lia-viam deleted the misc-proto-update branch December 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants