Remove DiscoverComponents #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randhid
requested review from
njooma and
stuqdog
and removed request for
a team
Collaborator
|
This is great thanks for the PR! Had to rebase against main since the last merge but will merge when the build passes. |
lia-viam
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're fully deprecating this API on March 10th 2025, but since the SDK team is gearing up to remove the instability notice and release v0.1.0, I thought perhaps we could remove this API from the C++ from the get-go.
This is my first contribution to the cpp-sdk, apologies for any obvious mistakes!