[RSDK-9624] Add discovery service #372
Conversation
randhid
force-pushed
the
discovery-service
branch
4 times, most recently
from
fb3daa6 to
75c73e4
Compare
| # Check if clang-format is installed | ||
| if ! command -v clang-format >/dev/null 2>&1; then | ||
| echo "Error: clang-format is not installed" | ||
| echo "Please install it using: brew install clang-format" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
I can remove this - but it helped me figure out clang-format wasn't installed through brew on my mac. The original error returned was that xargs couldn't find a file.
randhid
requested review from
njooma and
stuqdog
and removed request for
a team
randhid
force-pushed
the
discovery-service
branch
from
bbe666d to
4b45a7e
Compare
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
One or two minor things but otherwise this looks good to me!
| } | ||
|
|
||
| ProtoStruct MockDiscovery::do_command(const sdk::ProtoStruct& command) { | ||
| return ProtoStruct{}; |
There was a problem hiding this comment.
(minor) can we return the fake_map here instead? I tend to prefer returning something that isn't just the default constructed value, just out of an abundance of caution.
lia-viam
left a comment
lia-viam
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge if you're done!
src/viam/sdk/services/discovery.hpp
Outdated
| /// | ||
| /// This acts as an abstract parent class to be inherited from by any drivers representing | ||
| /// specific discovery implementations. This class cannot be used on its own. | ||
|
|
There was a problem hiding this comment.
I think this line needs to be deleted for the doxygen comment to bind
There was a problem hiding this comment.
Do I need to build docs locally as well or will CI do that?
Co-authored-by: lia <167905060+lia-viam@users.noreply.github.com>
Co-authored-by: lia <167905060+lia-viam@users.noreply.github.com>
This PR adds the Discovery Service wrapper to the C++ SDK.
I mainly followed the pattern in #323.
I followed the
arm.get_geometriesmethod pattern to return an array of aResourceConfigfromdiscovery.discover_resources, which is intended to return a valid config with meaningful attributes for physically connected devices to viam-server.