RSDK-9901 - run tests in update proto workflow #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
lia-viam and
njooma
and removed request for
a team
Collaborator
|
This seems straightforward and I'm provisionally ready to approve, I guess we won't know for sure if it worked until it's merged and a new proto update comes in though? |
njooma
approved these changes
Mar 10, 2025
Member
Author
Yep! I think the stakes here are extremely low and the process of testing is a bit complicated, so just going with the "this probably works and if it doesn't we can fix at that time" approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets a new token for checkout step to cause tests to run during proto update workflow.
Unlike viamrobotics/viam-python-sdk#864, we use
GIT_ACCESS_TOKENinstead ofREPO_READ_TOKEN.REPO_READ_TOKENdoes not exist in this repo's secrets, and per @abe-winter theGIT_ACCESS_TOKENmay work as well. If it does not, we can revisit.