Fix conan build failures #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
stuqdog
and removed request for
a team
stuqdog
reviewed
Mar 11, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
Abstractly this looks reasonable to me, though I'm curious as to why the tests are now failing?
stuqdog
approved these changes
Mar 14, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
per offline convo, lgtm as a "let's lock in what gains we can" fix. if/when it becomes relevant, we can revisit why a couple tests are still failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conan build has been broken as of https://github.com/viamrobotics/viam-cpp-sdk/actions/runs/13652553282
It seems that the release of grpc 1.69 conan package is causing a version conflict with abseil. However, as of #357 there is no longer any direct consumption of abseil in SDK/API code, so it should be fine to remove the dependency from conan entirely.