Skip to content

conformant ref qualified overloads #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

conformant ref qualified overloads #393

merged 2 commits into from
Mar 31, 2025

Conversation

@lia-viam
Copy link
Collaborator

@lia-viam lia-viam commented Mar 25, 2025

MSVC revealed that the way I was previously overloading member functions was not legal. In particular you can't do

struct X {
    void f(); // no ref qualifier
    void f() const& // ref qualifier
};

@lia-viam lia-viam requested a review from a team as a code owner March 25, 2025 15:02
@lia-viam lia-viam requested review from njooma and stuqdog and removed request for a team March 25, 2025 15:02
acmorrow
acmorrow approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@acmorrow acmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lia-viam lia-viam merged commit 3734b5a into viamrobotics:main Mar 31, 2025
4 checks passed
@lia-viam lia-viam deleted the fix/ref-qual branch March 31, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acmorrow acmorrow acmorrow approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

@stuqdog stuqdog Awaiting requested review from stuqdog stuqdog is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lia-viam @acmorrow