RSDK-838: Rebuild with latest proto definitions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ah I ran the webrtc for java via rosetta |
edaniels
approved these changes
Dec 30, 2022
Contributor
edaniels
left a comment
edaniels
left a comment
There was a problem hiding this comment.
LGTM. should have mentioned rosetta in README, sorry!
|
|
||
| run_client: | ||
| ./gradlew runClient --args="localhost:8080" | ||
| ./gradlew runExample1Client --args="localhost:8080" |
Member
Author
I didn't know Rosetta existed! I submitted a pr to the maintainer to get official support as I'm sure it'll come up at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped dependency versions while I was there.
Server/Client samples work.
Had to build webrtc-java locally since there's no M1 package. Will update the README with instructions once I get the process a bit cleaner.