Skip to content

Conversation

@edaniels
Copy link
Contributor

  • Add RobotClient
  • Add Registry
  • Add ResourceManager
  • Add Server
  • Add Gripper and Generic (mostly for testing)

@edaniels edaniels requested a review from njooma February 19, 2024 02:50
@njooma
Copy link
Member

njooma commented Feb 21, 2024

Working my way through this but a question about structure: why is there a java.sdk.src package that includes classes that maybe should be in core?

Is it because that these are the classes that must use different resources depending on whether it is Android or Java?

@edaniels
Copy link
Contributor Author

Working my way through this but a question about structure: why is there a java.sdk.src package that includes classes that maybe should be in core?

Is it because that these are the classes that must use different resources depending on whether it is Android or Java?

Yes, each of those classes in viam-java-sdk and viam-android-sdk extend/implement classes/interfaces from viam-core-sdk. This is due to differences in the platforms.

@edaniels edaniels merged commit ffe4993 into viamrobotics:main Feb 29, 2024
@edaniels edaniels deleted the android_mod branch February 29, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants