Skip to content

Conversation

@lia-viam
Copy link
Contributor

@lia-viam lia-viam commented Nov 6, 2025

Implements and tests a ResourceDataConsumer class that can be used as a base to obtain historical module data

Not sure if I did the mocking correctly, this seemed to be what I had to copy from other unit tests to make ViamClient construction work. Also maybe I did the patch calls wrong because it would not let me await the method I'm testing

@lia-viam lia-viam requested review from njooma and stuqdog November 6, 2025 21:20
@lia-viam lia-viam requested a review from a team as a code owner November 6, 2025 21:20
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(chatted offline with @lia-viam about fixing the async issues)

@lia-viam lia-viam requested a review from stuqdog November 11, 2025 16:20
@lia-viam lia-viam merged commit 9ac48ad into viamrobotics:main Nov 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants