Handle exceptional errors when retrying connections #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-transport-and-signaling-client-for-dialing-webrtc
This reverts commit 8c20e5b.
…' into dont-swallow-errors-when-dialing
DTCurrie
requested review from
lia-viam and
njooma
and removed request for
a team
…' into dont-swallow-errors-when-dialing
DTCurrie
commented
Nov 14, 2025
Comment on lines
+143
to
+153
| [ | ||
| Code.Canceled, | ||
| Code.InvalidArgument, | ||
| Code.NotFound, | ||
| Code.AlreadyExists, | ||
| Code.PermissionDenied, | ||
| Code.FailedPrecondition, | ||
| Code.OutOfRange, | ||
| Code.Unimplemented, | ||
| Code.Unauthenticated, | ||
| ].includes(error.code) |
Member
Author
There was a problem hiding this comment.
Let me know if we should add/remove anything from this list.
…to reuse-transport-and-signaling-client-for-dialing-webrtc
…to dont-swallow-errors-when-dialing
…' into dont-swallow-errors-when-dialing
…to dont-retry-on-exceptional-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
RobotClient's connection logic would attempt to retry on all errors, regardless of whether they were recoverable. This led to unnecessary retry cycles on fatal errors such as authentication failures, invalid arguments, or configuration issues.This change introduces error classification into the client's connection and reconnection logic to prevent retries on non-recoverable errors.