feat: extensible import-tree API #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an extensible API layer to the existing import-tree builder, allowing users and library authors to register custom methods that carry forward through chained calls.
- Introduce an
apifield and a newaddAPImethod indefault.nix - Add tests in
checkmate.nixto validate extending and preserving custom API methods - Update
README.mdto replace “builder API” with “extensible API” and documentaddAPIusage
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| default.nix | Initialize api, adjust __functor to merge in api, add addAPI method |
| checkmate.nix | Add two tests under addAPI. to verify that new methods are added and previous ones persist |
| README.md | Rename “builder API” → “extensible API,” and document the new addAPI function |
Comments suppressed due to low confidence (1)
README.md:235
- Documentation says each function takes a single
selfargument, but example functions also accept extra parameters (e.g.,featureName). Please clarify the signature to reflect variable arity.
`addAPI` takes an attribute set of functions taking a single argument:
vic
force-pushed
the
vic/jj-change-wrpowwkxzpvw
branch
from
d80c3cd to
2f297f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.