Skip to content

Commit 46779e8

Browse files
authored
fix: convert Tracklist length to a getter and fix event docs (#9142)
1 parent 08f3ee3 commit 46779e8

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

src/js/tracks/track-list.js

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,20 @@ class TrackList extends EventTarget {
2626

2727
this.tracks_ = [];
2828

29-
/**
30-
* @memberof TrackList
31-
* @member {number} length
32-
* The current number of `Track`s in the this Trackist.
33-
* @instance
34-
*/
35-
Object.defineProperty(this, 'length', {
36-
get() {
37-
return this.tracks_.length;
38-
}
39-
});
40-
4129
for (let i = 0; i < tracks.length; i++) {
4230
this.addTrack(tracks[i]);
4331
}
4432
}
4533

34+
/**
35+
* The current number of `Track`s in this TrackList.
36+
*
37+
* @type {number}
38+
*/
39+
get length() {
40+
return this.tracks_.length;
41+
}
42+
4643
/**
4744
* Add a {@link Track} to the `TrackList`
4845
*
@@ -83,10 +80,10 @@ class TrackList extends EventTarget {
8380
/**
8481
* Triggered when a track label is changed.
8582
*
86-
* @event TrackList#addtrack
83+
* @event TrackList#labelchange
8784
* @type {Event}
8885
* @property {Track} track
89-
* A reference to track that was added.
86+
* A reference to track whose label was changed.
9087
*/
9188
track.labelchange_ = () => {
9289
this.trigger({

0 commit comments

Comments
 (0)