Skip to content
This repository was archived by the owner on May 2, 2023. It is now read-only.
This repository was archived by the owner on May 2, 2023. It is now read-only.

SemVerException not Being Thrown #39

@jonmchan

Description

@jonmchan

According to the phpdoc - https://github.com/vierbergenlars/php-semver/blob/2.x/src/vierbergenlars/SemVer/version.php#L26:

    /**
     * Initializes the version object with a simple version
     * @param  string          $version A simple, single version string
     * @param  bool            $loose
     * @throws SemVerException
     */
    public function __construct($version, $loose = false)
    {
        $this->version = new SemVer($version, $loose);
    }

but SemVer constructor actually throws \RuntimeException - https://github.com/vierbergenlars/php-semver/blob/master/src/vierbergenlars/SemVer/internal.php#L329. We need to either fix the documentation or what is being thrown.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions