Refactored argmin and argmax into an extension trait for Iterator and moved argmin_filtered and argmax_filtered into compute.rs #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolver 3 requires dependent crates referencing the git repo to have resolver 3 themselves, which requires edition 2024. edition 2024 requires rustc 1.85 released last month and non-trivial changes in some of said crates, so it is a bit early to require it now.
Use resolver 2 instead of 3
There is no reason to depend on edition 2021 yet, and it requires a very recent compiler (1.85, released last month)
Switch from edition 2024 to 2021
… to a temporary file which is then renamed
… argmin_filtered and argmax_filtered inside computer.rs as it's the only user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the implementations of
arg{min, max}andarg{min, max}_filtered.Argmin and argmax are helpful in general, so I refactored them into an extension trait for Iterator.
Meanwhile,
arg_{min, max}_filteredare only used bycomputer.rs, so I moved them there.