Skip to content

par_sort_pairs: Add support for parallel iterators of Result #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

par_sort_pairs: Add support for parallel iterators of Result #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions webgraph/src/utils/par_sort_pairs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,23 @@ impl ParSortPairs<()> {
pub fn par_sort_pairs(
&self,
pairs: impl ParallelIterator<Item = (usize, usize)>,
) -> Result<Vec<impl IntoIterator<Item = (usize, usize), IntoIter: Clone + Send + Sync>>> {
self.try_par_sort_pairs::<std::convert::Infallible>(pairs.map(Ok))
}

pub fn try_par_sort_pairs<E: Into<anyhow::Error>>(
&self,
pairs: impl ParallelIterator<Item = Result<(usize, usize), E>>,
) -> Result<Vec<impl IntoIterator<Item = (usize, usize), IntoIter: Clone + Send + Sync>>> {
Ok(self
.par_sort_labeled_pairs(&(), (), pairs.map(|(src, dst)| (src, dst, ())))?
.try_par_sort_labeled_pairs(
&(),
(),
pairs.map(|pair| -> Result<_> {
let (src, dst) = pair.map_err(Into::into)?;
Ok((src, dst, ()))
}),
)?
.into_iter()
.map(|into_iter| into_iter.into_iter().map(|(src, dst, ())| (src, dst)))
.collect())
Expand Down Expand Up @@ -163,6 +177,35 @@ impl<L> ParSortPairs<L> {
>,
>,
>
where
L: Copy + Send + Sync,
S: Sync + BitSerializer<NE, BitWriter, SerType = L>,
D: Clone + Send + Sync + BitDeserializer<NE, BitReader, DeserType: Copy + Send + Sync>,
{
self.try_par_sort_labeled_pairs::<S, D, std::convert::Infallible>(
serializer,
deserializer,
pairs.map(Ok),
)
}

pub fn try_par_sort_labeled_pairs<S, D, E: Into<anyhow::Error>>(
&self,
serializer: &S,
deserializer: D,
pairs: impl ParallelIterator<Item = Result<(usize, usize, L), E>>,
) -> Result<
Vec<
impl IntoIterator<
Item = (
usize,
usize,
<D as BitDeserializer<NE, BitReader>>::DeserType,
),
IntoIter: Clone + Send + Sync,
>,
>,
>
where
L: Copy + Send + Sync,
S: Sync + BitSerializer<NE, BitWriter, SerType = L>,
Expand Down Expand Up @@ -221,7 +264,8 @@ impl<L> ParSortPairs<L> {
.borrow_mut(),
)
},
|(pl, thread_state), (src, dst, label)| -> Result<_> {
|(pl, thread_state), pair| -> Result<_> {
let (src, dst, label) = pair.map_err(Into::into)?;
ensure!(
src < self.num_nodes,
"Expected {}, but got {src}",
Expand Down