-
Notifications
You must be signed in to change notification settings - Fork 19
👍 Use Call type from @denops/core v8.0.1 #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apply the new `Call` type introduced in @denops/core v8.0.1 (PR #16). This replaces the duplicated tuple type `[string, ...unknown[]]` with the standardized `Call` type, improving type consistency and maintainability across the codebase. Related: vim-denops/deno-denops-core#16
WalkthroughThe pull request introduces a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes These are straightforward, homogeneous type-level changes replacing tuple definitions with an imported type alias. No runtime logic modifications or control flow alterations are present. Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 64 64
Lines 2879 2879
Branches 281 281
=======================================
Hits 2442 2442
Misses 435 435
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI failed with denoland/deno#30924. The problem still exists in Deno 2.5.4 (on Windows). |
Apply the new
Calltype introduced in @denops/core v8.0.1 (vim-denops/deno-denops-core#16).This replaces the duplicated tuple type
[string, ...unknown[]]with the standardizedCalltype, improving type consistency and maintainability across the codebase.The
Calltype is re-exported so that libraries that use@denops/stdcan reuse it.Summary by CodeRabbit
Refactor
Chores