Skip to content

Conversation

@Milly
Copy link
Contributor

@Milly Milly commented Oct 19, 2025

Apply the new Call type introduced in @denops/core v8.0.1 (vim-denops/deno-denops-core#16).
This replaces the duplicated tuple type [string, ...unknown[]] with the standardized Call type, improving type consistency and maintainability across the codebase.

The Call type is re-exported so that libraries that use @denops/std can reuse it.

Summary by CodeRabbit

  • Refactor

    • Improved internal type definitions for batch call handling to use standardized type representations, enhancing code consistency and maintainability.
  • Chores

    • Updated dependency version constraint for core library compatibility.

Milly added 2 commits October 19, 2025 09:24
Apply the new `Call` type introduced in @denops/core v8.0.1 (PR #16).
This replaces the duplicated tuple type `[string, ...unknown[]]` with
the standardized `Call` type, improving type consistency and
maintainability across the codebase.

Related: vim-denops/deno-denops-core#16
@coderabbitai
Copy link

coderabbitai bot commented Oct 19, 2025

Walkthrough

The pull request introduces a new Call type from @denops/core across batch and eval modules, replacing inline tuple type [string, ...unknown[]] definitions with the imported Call type for consistent type representation. Version constraint for @denops/core is updated in configuration.

Changes

Cohort / File(s) Summary
Batch module type updates
batch/batch.ts, batch/collect.ts
Import Call type from @denops/core; replace #calls: [string, ...unknown[]][] with #calls: Call[]; update getCalls() and batch() method signatures to use Call[] instead of tuple arrays. collect.ts also removes readonly modifier from mapped type.
Configuration
deno.jsonc
Bump @denops/core version constraint from ^8.0.0 to ^8.0.1.
Eval module type updates
eval/use_eval.ts
Import Call type; update batch() method parameter from [string, ...unknown[]][] to Call[]; adjust internal map callback return type to Call.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

These are straightforward, homogeneous type-level changes replacing tuple definitions with an imported type alias. No runtime logic modifications or control flow alterations are present.

Poem

🐰 Hoppity hop, the types align,
Call types gather, so fine!
Tuples begone, now crisp and neat,
From denops core, a treat complete! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title ":+1: Use Call type from @denops/core v8.0.1" directly and accurately describes the main change across the entire pull request. The changeset primarily replaces the duplicated tuple type [string, ...unknown[]] with the standardized Call type imported from the updated @denops/core dependency (v8.0.1) across multiple files (batch/batch.ts, batch/collect.ts, eval/use_eval.ts), along with updating the version constraint in deno.jsonc. The title is specific, clear, and concisely communicates what was changed and from where, allowing teammates to quickly understand the purpose of the PR. While the emoji adds minor stylistic noise, it does not detract from the clarity and accuracy of the core message.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-call-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (39c1554) to head (fcabe6c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          64       64           
  Lines        2879     2879           
  Branches      281      281           
=======================================
  Hits         2442     2442           
  Misses        435      435           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Milly
Copy link
Contributor Author

Milly commented Oct 19, 2025

CI failed with denoland/deno#30924. The problem still exists in Deno 2.5.4 (on Windows).

@Milly Milly requested a review from lambdalisue October 19, 2025 01:00
@lambdalisue lambdalisue merged commit d8bfd9d into main Oct 19, 2025
23 of 26 checks passed
@lambdalisue lambdalisue deleted the use-call-type branch October 19, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants