Support default args #159
Support default args #159
Conversation
Compile result is changed.
test/test_xxx_funcarg_last_comma.ok
Outdated
| (function (F a)) | ||
| (function (G a)) | ||
| (function (F) (a)) | ||
| (function (G) (a)) |
There was a problem hiding this comment.
I wonder that this is breaking AST for function node?
There was a problem hiding this comment.
Changed.
from
(function (F) (a))
to
(function (F (a)))
There was a problem hiding this comment.
Update
function! F(a, b = 2) : (function (F (a) (b 2)))
function! F(a = 1 + 1, b = 2) : (function (F (a (+ 1 1)) (b 2)))
function! F(a = 1, b = 2, ...) : (function (F (a 1) (b 2) . ...))
There was a problem hiding this comment.
Ah, realized that to omit parenthesis if there's no default args resolves around backward compatibility. And that seems preferable.
There was a problem hiding this comment.
Update
function! F(a, b = 2) : (function (F a (b 2)))
| @@ -0,0 +1,2 @@ | |||
| function Foo(abc=1, xyz) | |||
| endfunction | |||
There was a problem hiding this comment.
Please add test for:
function X(foo=1+2)
return a:foo
endfunction
There was a problem hiding this comment.
Added test/test_funcarg_default.vim
|
Seems good to me. Pass to another look. |
| @@ -2,6 +2,9 @@ | |||
| function s:foo(a, b, ...) | |||
| return 0 | |||
| endfunction | |||
| function s:bar(a = 1, b = 2, ...) | |||
| return 0 | |||
| endfunction | |||
There was a problem hiding this comment.
Please add this too.
function s:baz(a, b = 2, ...)
return 0
endfunction
|
Thanks! |
Fix #154
Is there any spec about Compiler AST ? I broke it a little around
:function.MEMO: https://github.com/vim/vim/blob/v8.2.0246/src/userfunc.c#L199-L236