chore: formatter/lintの設定 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ESLint configuration from a JSR-hosted package to a standard npm package, upgrades dependencies, and applies automated code formatting fixes. The changes include reorganizing imports alphabetically, improving code quality by removing unused variables, and enabling ESLint in the CI workflow.
Key changes:
- Upgrades
@ryoppippi/eslint-configfrom JSR version 0.0.25 to npm version 0.4.0 - Updates pnpm from 10.4.0 to 10.20.0
- Adds ESLint execution to CI workflow
- Applies automated import sorting and code fixes
Reviewed Changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| 2025/package.json | Updates dependency versions, adds lint:fix script, removes JSR registry reference |
| 2025/eslint.config.mjs | Adds stylistic and formatters configuration options |
| 2025/.npmrc | Removes JSR registry configuration |
| Multiple .astro files | Alphabetically sorts imports |
| 2025/src/consts/index.ts | Removes eslint-disable comment |
| 2025/src/components/Sponsors/Individual.astro | Removes unused catch parameter |
| 2025/src/components/Sponsors/Company.astro | Changes string concatenation to template literal |
| 2025/src/components/Sponsors/Companies.astro | Converts arrow function to function declaration |
| 2025/src/components/Sessions/index.ts | Changes nullish check from falsy to explicit |
| 2025/src/components/Schedule/index.ts | Converts arrow functions to function declarations |
| 2025/src/components/Sessions/Session.astro | Improves template literal formatting |
| 2025/src/components/OgImage.tsx | Reorganizes imports |
| 2025/src/components/VimLogo.astro | Adds explicit Buffer import |
| 2025/pnpm-lock.yaml | Updates lockfile with new dependency versions |
| .github/workflows/lint.yml | Adds pnpm lint step to CI |
Files not reviewed (1)
- 2025/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryoppippi
force-pushed
the
fix-format
branch
2 times, most recently
from
ccb7d19 to
6a7db48
Compare
ryoppippi
commented
Nov 8, 2025
Comment on lines
+7
to
+8
| stylistic: false, | ||
| formatters: false, |
Member
Author
There was a problem hiding this comment.
stylisticとformattersがprettierと競合してたので無効にしました
Member
Author
|
okならマージしちゃって構いません！ |
Member
Author
|
node バイナリ周りはまた別のPRでやる |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.