Skip to content

migrate to php-parser v3.x #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2018
Merged

migrate to php-parser v3.x #78

merged 2 commits into from
Feb 5, 2018

Conversation

taoso
Copy link
Contributor

@taoso taoso commented Dec 16, 2017

migrate again

@taoso
Copy link
Contributor Author

taoso commented Dec 16, 2017

Hello guys @EvanDotPro @gianarb @sensorario @shawncplus @weynhamz

The php 7.2 has been released. And the php-parser v1.x is too old to support the new php version.

We need to migrate the php-parser to the latest version. And it is time to only support PHP 5.6+ and PHP 7.x.

@taoso
Copy link
Contributor Author

taoso commented Dec 16, 2017

By the way, I am a PHP developer and a heavy Vim/NeoVim user. I am maintaining the phpcd.vim and phpfold.vim, both of which make Vim/NeoVim better for PHP developing.

And I would like to apply to join your php-vim group, and make Vim/NeoVim better for PHP developer.

@taoso taoso mentioned this pull request Dec 16, 2017
@taoso
Copy link
Contributor Author

taoso commented Dec 27, 2017

Is there any body?

@mgallego
Copy link

mgallego commented Feb 2, 2018

Please review and accept the PR if is possible

@gianarb gianarb merged commit eedfec3 into vim-php:master Feb 5, 2018
@gianarb
Copy link
Contributor

gianarb commented Feb 5, 2018

Thanks guys and sorry for the huge delay

@taoso
Copy link
Contributor Author

taoso commented Feb 5, 2018

@gianarb would you like to make me join your group?

@gnumoksha gnumoksha mentioned this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants