runtime(cmake): sync runtime files with upstream #13597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkearns
requested changes
Nov 30, 2023
Contributor
dkearns
left a comment
dkearns
left a comment
There was a problem hiding this comment.
Thanks for the update.
It looks like this is maintained and distributed as part of the CMake project. If you're managing updates to the Vim distribution, rather than Dimitri, it might be a good idea to also list yourself as a maintainer in the header and add yourself to https://github.com/vim/vim/blob/master/.github/CODEOWNERS
@chrisbra might have some thoughts on how to manage this scenario.
Member
|
Thanks, I don't have anything more to add, you covered it all :) |
Contributor
Author
Contributor
Author
|
The upstream is https://github.com/pboettch/vim-cmake-syntax. |
Member
|
so is this ready? Or is there anything missing? |
e-kwsm
force-pushed
the
cmake
branch
2 times, most recently
from
52849f3 to
badfef0
Compare
Contributor
Author
|
Ready but pboettch/vim-cmake-syntax#33 is not merged. |
chrisbra
reviewed
Dec 8, 2023
clason
added a commit
to clason/neovim
that referenced
this pull request
Dec 15, 2023
runtime(cmake): sync runtime files with upstream (vim/vim#13597) vim/vim@3afc9f2 Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Dec 15, 2023
runtime(cmake): sync runtime files with upstream (vim/vim#13597) vim/vim@3afc9f2 Co-authored-by: Eisuke Kawashima <e-kwsm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.