Fix: cannot complete filter command with some patterns #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ichizok(Ozaki Kiichi),
2016-12-4(Sun) 13:24:08 UTC+9 ichizok:
This patch fixes completion behavior of :filter command.
repro steps
vim -Nu NONE
OK
regexp with slash
:filter /pat/ pri and input <TAB>, completion is done: :filter /pat/ print
FAIL
string
:filter pat pri and input <TAB>, but no completion: :filter pat pri
regexp with other than slash
:filter #pat# pri and input <TAB>, but no completion: :filter #pat# pri
completion by <C-D> is too.
You can view, comment on, or merge this pull request online at:
#1299
Commit Summary
Enable completion of filter-command
Add filter-cmd completion test
File Changes
M
src/ex_docmd.c
(11)
M
src/testdir/test_filter_cmd.vim
(22)
Patch Links:
https://github.com/vim/vim/pull/1299.patch
https://github.com/vim/vim/pull/1299.diff
Kiichi>
Let me unify the patch author names?
…--
Best regards,
Hirohito Higashi (a.k.a. h_east)
|
|
Ichizok wrote:
What do you mean?
The forwarded messages make it a bit difficult to see real names, it
only has the Github user name.
…--
From "know your smileys":
:-H Is missing teeth
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
I'm sorry for my vague comment, but I meant that my real name is "Ozaki Kiichi". |
Then you should set that in your GitHub profile. |
ichizok
force-pushed
the
fix/filter-expand
branch
from
73d778a to
c514d09
Compare
brammool
added a commit
that referenced
this pull request
Jan 7, 2017
Problem: When the pattern of :filter does not have a separator then
completion of the command fails.
Solution: Skip over the pattern. (Ozaki Kiichi, clodes #1299)
Merged
1 task
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Apr 30, 2017
Problem: When the pattern of :filter does not have a separator then
completion of the command fails.
Solution: Skip over the pattern. (Ozaki Kiichi, clodes vim/vim#1299)
vim/vim@7069bf1
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Apr 30, 2017
Problem: When the pattern of :filter does not have a separator then
completion of the command fails.
Solution: Skip over the pattern. (Ozaki Kiichi, clodes vim/vim#1299)
vim/vim@7069bf1
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: When the pattern of :filter does not have a separator then
completion of the command fails.
Solution: Skip over the pattern. (Ozaki Kiichi, clodes vim#1299)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes completion behavior of
:filtercommand.repro steps
vim -Nu NONEOK
regexp with slash
:filter /pat/ priand input<TAB>, completion is done::filter /pat/ printFAIL
string
:filter pat priand input<TAB>, but no completion::filter pat priregexp with other than slash
:filter #pat# priand input<TAB>, but no completion::filter #pat# pricompletion by
<C-D>is too.