Add support for specifying cookie domain with JWT_COOKIE_DOMAIN #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! :) instead of doing the .get(value, None), could you set the default value in jwt manager, just to keep things consistent? Thanks for contributing! I'll get a new version of this pushed out later tonight 👍 |
|
done, thanks for the fast response! |
|
Perfect, thanks! :) I'll get a new version released before I go to bed tonight. Cheers. |
|
Released as 1.4.1 👍 |
|
I am having trouble getting this feature to work, and the documentation doesn't really explain it. Could an example please be included in the docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to specify the cookie domain so that I can access the cookies on subdomains; this PR implements an optional
JWT_COOKIE_DOMAINconfig variable which will let that be set.