Skip to content

Add support for specifying cookie domain with JWT_COOKIE_DOMAIN #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2017
Merged

Add support for specifying cookie domain with JWT_COOKIE_DOMAIN #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6d018
add support for specifying cookie domain with JWT_COOKIE_DOMAIN
frnsys Apr 15, 2017
3565fc1
set JWT_COOKIE_DOMAIN default in the manager
frnsys Apr 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion flask_jwt_extended/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class _Config(object):
Helper object for accessing and verifying options in this extension. This
is meant for internal use of the application; modifying config options
should be done with flasks ```app.config```.

Default values for the configuration options are set in the jwt_manager
object. All of these values are read only.
"""
Expand Down Expand Up @@ -65,6 +65,10 @@ def refresh_cookie_path(self):
def cookie_secure(self):
return current_app.config['JWT_COOKIE_SECURE']

@property
def cookie_domain(self):
return current_app.config['JWT_COOKIE_DOMAIN']

@property
def session_cookie(self):
return current_app.config['JWT_SESSION_COOKIE']
Expand Down
1 change: 1 addition & 0 deletions flask_jwt_extended/jwt_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def _set_default_configuration_options(app):
app.config.setdefault('JWT_ACCESS_COOKIE_PATH', '/')
app.config.setdefault('JWT_REFRESH_COOKIE_PATH', '/')
app.config.setdefault('JWT_COOKIE_SECURE', False)
app.config.setdefault('JWT_COOKIE_DOMAIN', None)
app.config.setdefault('JWT_SESSION_COOKIE', True)

# Options for using double submit csrf protection
Expand Down
8 changes: 8 additions & 0 deletions flask_jwt_extended/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def set_access_cookies(response, encoded_access_token):
max_age=config.cookie_max_age,
secure=config.cookie_secure,
httponly=True,
domain=config.cookie_domain,
path=config.access_cookie_path)

# If enabled, set the csrf double submit access cookie
Expand All @@ -79,6 +80,7 @@ def set_access_cookies(response, encoded_access_token):
max_age=config.cookie_max_age,
secure=config.cookie_secure,
httponly=False,
domain=config.cookie_domain,
path=config.access_csrf_cookie_path)


Expand All @@ -97,6 +99,7 @@ def set_refresh_cookies(response, encoded_refresh_token):
max_age=config.cookie_max_age,
secure=config.cookie_secure,
httponly=True,
domain=config.cookie_domain,
path=config.refresh_cookie_path)

# If enabled, set the csrf double submit refresh cookie
Expand All @@ -106,6 +109,7 @@ def set_refresh_cookies(response, encoded_refresh_token):
max_age=config.cookie_max_age,
secure=config.cookie_secure,
httponly=False,
domain=config.cookie_domain,
path=config.refresh_csrf_cookie_path)


Expand All @@ -124,12 +128,14 @@ def unset_jwt_cookies(response):
expires=0,
secure=config.cookie_secure,
httponly=True,
domain=config.cookie_domain,
path=config.refresh_cookie_path)
response.set_cookie(config.access_cookie_name,
value='',
expires=0,
secure=config.cookie_secure,
httponly=True,
domain=config.cookie_domain,
path=config.access_cookie_path)

if config.csrf_protect and config.csrf_in_cookies:
Expand All @@ -138,10 +144,12 @@ def unset_jwt_cookies(response):
expires=0,
secure=config.cookie_secure,
httponly=False,
domain=config.cookie_domain,
path=config.refresh_csrf_cookie_path)
response.set_cookie(config.access_csrf_cookie_name,
value='',
expires=0,
secure=config.cookie_secure,
httponly=False,
domain=config.cookie_domain,
path=config.access_csrf_cookie_path)