Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARTO v9 API RFC #8051

Merged
merged 12 commits into from
Sep 29, 2023
Merged

CARTO v9 API RFC #8051

merged 12 commits into from
Sep 29, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #8047

Copy link
Contributor

@alasarr alasarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for setting this RFC @felixpalmer! I have added some comments.

We also need to define here how fetchLayerData will be affected.

dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Show resolved Hide resolved
dev-docs/RFCs/v8.0/carto-v9-rfc.md Outdated Show resolved Hide resolved
@alasarr alasarr requested a review from padawannn August 14, 2023 13:07
Copy link
Collaborator

@padawannn padawannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with the dynamic aggregation? I mean, if you have a point table that you want to aggregate dynamically using Quandbin, must you use a CartoVectorTableSource with an aggregation expression to render a CartoQuadbinTileLayer layer? I think it's a little confusing

@felixpalmer
Copy link
Collaborator Author

What happens with the dynamic aggregation? I mean, if you have a point table that you want to aggregate dynamically using Quandbin, must you use a CartoVectorTableSource with an aggregation expression to render a CartoQuadbinTileLayer layer? I think it's a little confusing

@padawannn wouldn't you just use a CartoQuadbinTableSource in that case? The CartoQuadbinTableSource is just basically a function that takes some parameters, converts them to a URL and fetches the tileJSON

@padawannn
Copy link
Collaborator

What happens with the dynamic aggregation? I mean, if you have a point table that you want to aggregate dynamically using Quandbin, must you use a CartoVectorTableSource with an aggregation expression to render a CartoQuadbinTileLayer layer? I think it's a little confusing

@padawannn wouldn't you just use a CartoQuadbinTableSource in that case? The CartoQuadbinTableSource is just basically a function that takes some parameters, converts them to a URL and fetches the tileJSON

So if I understand well, it would be a CartoQuadbinTableSource and we would have to set the spatialDataColumn parameter, right? Internally we would call the Maps API with geoColum=quadbin:geom if we would set the spatialDataColumn as geom

@felixpalmer

@felixpalmer felixpalmer merged commit 401d624 into master Sep 29, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/carto-v9-rfc branch September 29, 2023 08:53
@felixpalmer felixpalmer mentioned this pull request Sep 29, 2023
14 tasks
Pessimistress pushed a commit that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants