fix: prevent api provider race condition, defer loading state update#970
Merged
usefulthink merged 1 commit intovisgl:mainfrom Apr 24, 2026
Merged
Conversation
usefulthink
approved these changes
Apr 24, 2026
Collaborator
usefulthink
left a comment
There was a problem hiding this comment.
Thanks! Seems like a simple enough fix that we can release it right away.
|
amazing, thanks for the quick fix ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced and confirmed problem and solution of #968 and applied suggested fix
Summary
Fixes an
APIProviderrace whengoogle.maps.importLibraryis already installed by an external loader, but the Maps JavaScript API has not finished loading yet.Previously, the external-loader fast path marked the API as
LOADEDbefore awaitingimportLibrary('core')andimportLibrary('maps'). This allowed provider effects and child components to run too early, causing errors such asgoogle.maps.Settings is undefinedorgoogle.maps.Map is not a constructor.Changes
APILoadingStatus.LOADEDin the external-loader fast path.google.maps.importLibrarywithgoogle.maps.Settingsinitially unavailable.closes #968