test: fix flaky test #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Jan 28, 2023
|
|
||
| test('hmr', async () => { | ||
| await page.goto(url) | ||
| await untilBrowserLogAfter(() => page.goto(url), 'hydrated') |
There was a problem hiding this comment.
This test should wait for hydration because HMR won't work before hydration like other tests.
|
|
||
| test(`circular dependencies modules doesn't throw`, async () => { | ||
| await page.goto(url) | ||
| await untilBrowserLogAfter(() => page.goto(url), 'hydrated') |
There was a problem hiding this comment.
This is not necessary but I think it's better to call this to make all tests consistent.
ArnaudBarre
approved these changes
Jan 28, 2023
|
Thanks didn't have time to look at it yet. If it worked on core this is safe to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to vitejs/vite#11077
This PR fixes these fails:
https://github.com/vitejs/vite-plugin-react/actions/runs/4006634908/jobs/6878421363#step:11:21
https://github.com/vitejs/vite-plugin-react/actions/runs/4030889354/jobs/6929846904#step:11:21
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).