Skip to content

test: fix flaky test #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023
Merged

test: fix flaky test #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions playground/ssr-react/__tests__/ssr-react.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ test('/', async () => {
})

test('hmr', async () => {
await page.goto(url)
await untilBrowserLogAfter(() => page.goto(url), 'hydrated')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test should wait for hydration because HMR won't work before hydration like other tests.


editFile('src/pages/Home.jsx', (code) =>
code.replace('<h1>Home', '<h1>changed'),
)
Expand All @@ -70,7 +71,8 @@ test('client navigation', async () => {
})

test(`circular dependencies modules doesn't throw`, async () => {
await page.goto(url)
await untilBrowserLogAfter(() => page.goto(url), 'hydrated')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary but I think it's better to call this to make all tests consistent.


expect(await page.textContent('.circ-dep-init')).toMatch(
'circ-dep-init-a circ-dep-init-b',
)
Expand Down