refactor: build --app

Author: patak-dev

docs/guide/api-vite-environment.md

@@ -821,13 +821,14 @@ Other non-default environments can be build using `vite build --environment=name
 
 ## Building all environments
 
-Calling `vite build --all` will instantiate a `ViteBuilder` (build-time equivalent to a `ViteDevServer`) to build all configured environments for production. By default the build of environments is run in series respecting the order of the `environments` record. A framework or user can further configure how the environments are built using:
+Calling `vite build --app` will instantiate a `ViteBuilder` (build-time equivalent to a `ViteDevServer`) to build all configured environments for production. By default the build of environments is run in series respecting the order of the `environments` record. A framework or user can further configure how the environments are built using:
 
 ```js
 export default {
   builder: {
-    buildEnvironments: asnyc (builder) => {
-      return Promise.all(Object.values(builder.environments).map( environment => builder.build(environment) ))
+    buildApp: asnyc (builder) => {
+      const environments = Object.values(builder.environments)
+      return Promise.all(environments.map(environment => builder.build(environment)))
     }
   }
 }

packages/vite/src/node/build.ts

@@ -1394,33 +1394,27 @@ export class BuildEnvironment extends Environment {
 export interface ViteBuilder {
   environments: Record<string, BuildEnvironment>
   config: ResolvedConfig
-  buildEnvironments(): Promise<void>
+  buildApp(): Promise<void>
   build(
     environment: BuildEnvironment,
   ): Promise<RollupOutput | RollupOutput[] | RollupWatcher>
 }
 
 export interface BuilderOptions {
-  buildEnvironments?: (
-    builder: ViteBuilder,
-    build: (environment: BuildEnvironment) => Promise<void>,
-  ) => Promise<void>
+  buildApp?: (builder: ViteBuilder) => Promise<void>
 }
 
-async function defaultBuildEnvironments(
-  builder: ViteBuilder,
-  build: (environment: BuildEnvironment) => Promise<void>,
-): Promise<void> {
+async function defaultBuildApp(builder: ViteBuilder): Promise<void> {
   for (const environment of Object.values(builder.environments)) {
-    await build(environment)
+    await builder.build(environment)
   }
 }
 
 export function resolveBuilderOptions(
   options: BuilderOptions = {},
 ): ResolvedBuilderOptions {
   return {
-    buildEnvironments: options.buildEnvironments ?? defaultBuildEnvironments,
+    buildApp: options.buildApp ?? defaultBuildApp,
   }
 }
 
@@ -1463,18 +1457,13 @@ export async function createViteBuilder(
   const builder: ViteBuilder = {
     environments,
     config: defaultConfig,
-    async buildEnvironments() {
+    async buildApp() {
       if (defaultConfig.build.watch) {
         throw new Error(
-          'Watch mode is not yet supported in viteBuilder.buildEnvironments()',
+          'Watch mode is not yet supported in viteBuilder.buildApp()',
         )
       }
-      return defaultConfig.builder.buildEnvironments(
-        builder,
-        async (environment) => {
-          await this.build(environment)
-        },
-      )
+      return defaultConfig.builder.buildApp(builder)
     },
     async build(environment: BuildEnvironment) {
       return buildEnvironment(environment.config, environment)

packages/vite/src/node/cli.ts

@@ -281,7 +281,7 @@ cli
   )
   .option('-w, --watch', `[boolean] rebuilds when modules have changed on disk`)
   .option('--environment [name]', `[string] build a single environment`)
-  .option('--all', `[boolean] build all environments`)
+  .option('--app', `[boolean] build all the environments`)
   .action(
     async (
       root: string,
@@ -316,8 +316,8 @@ cli
             }
             await builder.build(environment)
           } else {
-            // --all: build all environments
-            await builder.buildEnvironments()
+            // --app: build all environments
+            await builder.buildApp()
           }
         } else {
           await build(config)

playground/environment-react-ssr/vite.config.ts

@@ -47,9 +47,9 @@ export default defineConfig((env) => ({
   },
 
   builder: {
-    async buildEnvironments(builder, build) {
-      await build(builder.environments.client)
-      await build(builder.environments.ssr)
+    async buildApp(builder) {
+      await builder.build(builder.environments.client)
+      await builder.build(builder.environments.ssr)
     },
   },
 }))

playground/vitestSetup.ts

@@ -260,7 +260,7 @@ export async function startDefaultServe(): Promise<void> {
     )
     if (buildConfig.builder) {
       const builder = await createViteBuilder({}, { root: rootDir })
-      await builder.buildEnvironments()
+      await builder.buildApp()
     } else {
       const rollupOutput = await build(buildConfig)
       const isWatch = !!resolvedConfig!.build.watch