Skip to content
This repository was archived by the owner on Sep 1, 2020. It is now read-only.

Conversation

@meikoudras
Copy link
Contributor

@vkbansal
Copy link
Owner

vkbansal commented Oct 4, 2015

Sorry for the late response, I'm out on vacation. Will be back in couple of days and have a look at this.

Thanks for your contribution:)

…ch screens where the menu closes before the event to click is triggered. This only happens when using multiple contex menus.
@meikoudras
Copy link
Contributor Author

Thanks for the response. I added a few more changes:

I changed that the contextmenu event listener to be on the document, since I noticed some times when redrawing the dom the original dom element listener gets lost and the contextmenu listener is not fired.

I also noticed with multiple context menus touch screens have an issue clicking menu items ( the menu disappears and no action is fired). You can reproduce it here: http://vkbansal.github.io/react-contextmenu/#/multiple-menus by turning on chrome device mode and choosing a touch screen device (eg. Nexus 10). Hold down the left mouse button for the context menu to appear and try clicking the menu item.

@vkbansal
Copy link
Owner

vkbansal commented Oct 5, 2015

@meikoudras Can you make these as separate PRs ?

vkbansal added a commit that referenced this pull request Oct 10, 2015
Enhancements for various devices
@vkbansal vkbansal merged commit 5f5447f into vkbansal:master Oct 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants