orm: add check for invalid index field name (#26142)

Author: kbkpbot

vlib/orm/orm.v

@@ -473,6 +473,8 @@ pub fn orm_table_gen(sql_dialect SQLDialect, table Table, q string, defaults boo
 	mut field_comments := map[string]string{}
 	mut index_fields := []string{}
 
+	valid_sql_field_names := fields.map(sql_field_name(it))
+
 	for attr in table.attrs {
 		match attr.name {
 			'comment' {
@@ -485,6 +487,9 @@ pub fn orm_table_gen(sql_dialect SQLDialect, table Table, q string, defaults boo
 					index_strings := attr.arg.split(',')
 					for i in index_strings {
 						x := i.trim_space()
+						if x !in valid_sql_field_names {
+							return error("table `${table.name}` has no field's name: `${x}`")
+						}
 						if x.len > 0 && x !in index_fields {
 							index_fields << x
 						}

vlib/orm/orm_func_test.v

@@ -583,3 +583,49 @@ fn test_orm_func_f32_f64() {
 	assert data.age_f32 == p.age_f32
 	assert data.age_f64 == p.age_f64
 }
+
+@[index: 'age_f33, age_f64']
+struct InvalidIndexFieldName1 {
+	age_f32 f32
+	age_f64 f64
+}
+
+fn test_orm_func_invalid_index_field_name1() {
+	p := InvalidIndexFieldName1{
+		age_f32: 10.33
+		age_f64: 10.343
+	}
+
+	db := sqlite.connect(':memory:')!
+
+	mut qb := orm.new_query[InvalidIndexFieldName1](db)
+
+	qb.create() or {
+		assert err.msg() == "table `InvalidIndexFieldName1` has no field's name: `age_f33`"
+		return
+	}
+	assert false, 'should not be here'
+}
+
+@[index: 'age_f32, age_f64']
+struct InvalidIndexFieldName2 {
+	age_f32 f32 @[sql: abc]
+	age_f64 f64
+}
+
+fn test_orm_func_invalid_index_field_name2() {
+	p := InvalidIndexFieldName2{
+		age_f32: 10.33
+		age_f64: 10.343
+	}
+
+	db := sqlite.connect(':memory:')!
+
+	mut qb := orm.new_query[InvalidIndexFieldName2](db)
+
+	qb.create() or {
+		assert err.msg() == "table `InvalidIndexFieldName2` has no field's name: `age_f32`"
+		return
+	}
+	assert false, 'should not be here'
+}