rand.xoroshiro128pp: prevent generation of extra zeros in u16() (#26229)

tankf33der · web-flow · commit a2e93ecca7ae · 2025-12-31T13:07:16.000+02:00
diff --git a/vlib/rand/xoroshiro128pp/xoros128pp.v b/vlib/rand/xoroshiro128pp/xoros128pp.v
@@ -48,8 +48,7 @@ pub fn (mut rng XOROS128PPRNG) u8() u8 {
 	ans := rng.u64()
 	rng.buffer = ans >> 8
 	rng.bytes_left = 7
-	value := u8(ans)
-	return value
+	return u8(ans)
 }
 
 // u16 returns a pseudorandom 16-bit unsigned integer (`u16`).
@@ -62,7 +61,7 @@ pub fn (mut rng XOROS128PPRNG) u16() u16 {
 		return value
 	}
 	ans := rng.u64()
-	rng.buffer = u32(ans >> 16)
+	rng.buffer = ans >> 16
 	rng.bytes_left = 6
 	return u16(ans)
 }

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,7 @@ pub fn (mut rng XOROS128PPRNG) u8() u8 {`
`48`	`48`	`ans := rng.u64()`
`49`	`49`	`rng.buffer = ans >> 8`
`50`	`50`	`rng.bytes_left = 7`
`51`		`- value := u8(ans)`
`52`		`- return value`
	`51`	`+ return u8(ans)`
`53`	`52`	`}`
`54`	`53`
`55`	`54`	// u16 returns a pseudorandom 16-bit unsigned integer (`u16`).
`@@ -62,7 +61,7 @@ pub fn (mut rng XOROS128PPRNG) u16() u16 {`
`62`	`61`	`return value`
`63`	`62`	`}`
`64`	`63`	`ans := rng.u64()`
`65`		`- rng.buffer = u32(ans >> 16)`
	`64`	`+ rng.buffer = ans >> 16`
`66`	`65`	`rng.bytes_left = 6`
`67`	`66`	`return u16(ans)`
`68`	`67`	`}`