Skip to content

[QuantizationScheme] Validate format #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[QuantizationScheme] Validate format #424

merged 1 commit into from
Aug 15, 2025

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Aug 15, 2025

  • Ensure per-module quantization schemes are not created with format as mixed-precision

@dsikka dsikka enabled auto-merge (squash) August 15, 2025 01:09
@dsikka dsikka requested a review from kylesayrs August 15, 2025 02:32
kylesayrs
kylesayrs approved these changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe format should be type hinted to be of CompressionFormat type?

@dsikka dsikka merged commit 05e00e4 into main Aug 15, 2025
1 check passed
@dsikka dsikka deleted the format_validation branch August 15, 2025 03:09
Etelis added a commit to Etelis/compressed-tensors that referenced this pull request Sep 11, 2025
@Etelis
add validation check on format (vllm-project#424)
aa121c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylesayrs kylesayrs kylesayrs approved these changes

@shanjiaz shanjiaz shanjiaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsikka @kylesayrs @shanjiaz