Skip to content

Conversation

@yankay
Copy link
Contributor

@yankay yankay commented Nov 20, 2025

Summary

From the log https://github.com/vllm-project/guidellm/actions/runs/18408284407/job/52453702204#step:5:468 , it can be seen that GUIDELLM_BUILD_TYPE=$GUIDELLM_BUILD_TYPE in the container file was not correctly assigned. The reason is that the ARG instructions defined before FROM are global but not available in the build stage context, which can lead to improper version tagging during the build process. This caused the container to use an incorrect version string. Ref to https://docs.docker.com/reference/dockerfile#understand-how-arg-and-from-interact

Details

Moved the ARG GUIDELLM_BUILD_TYPE=dev instruction and its explanatory comments after the FROM $BASE_IMAGE as builder statement. This ensures the build type argument is properly scoped to the build stage.

Test Plan

  • In this branch, create a tag such as v0.3.2 and build using buildah build --build-arg GUIDELLM_BUILD_TYPE=release, then check if the logs return the correct version.

Related Issues


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sjmonson sjmonson merged commit 094fc93 into vllm-project:main Nov 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.3.1 container includes v0.4.0.dev0 GuideLLM python package

2 participants