Skip to content

Conversation

@tukwila
Copy link
Contributor

@tukwila tukwila commented Nov 27, 2025

Summary

pytest tests/unit/extras/test_vision.py
pytest tests/unit/extras/test_audio.py

Details

  • [ ]

Test Plan

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@tukwila
Copy link
Contributor Author

tukwila commented Nov 28, 2025

@sjmonson i add some audio/vision ut but the job unit-tests fail in the cmd: pip install tox tox-pdm:

image

and i checked out you add ffmpeg installation in the Containerfile, i don't know why it fail. Do you know?

@sjmonson
Copy link
Collaborator

sjmonson commented Dec 2, 2025

The workflows don't use the container build; that is a good idea for the future. For now I will see if I can just get it installed in the worker as part of the tox action.

@sjmonson sjmonson added this to the v0.4.1 milestone Dec 2, 2025
Copy link
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add the following right above "Install dependencies" in .github/actions/run-tox/action.yml:

    - name: Install system dependencies
      run: |
        sudo apt install -y ffmpeg
      shell: bash

Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Should be good once you update CI to have the required dependency.

Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@sjmonson sjmonson merged commit fce8858 into vllm-project:main Dec 3, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants